chore: Start adding XCUITest driver options #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
reviewed
Oct 26, 2021
.../io/appium/java_client/ios/options/general/SupportsIncludeDeviceCapsToSessionInfoOption.java
Show resolved
Hide resolved
valfirst
reviewed
Oct 26, 2021
| @Deprecated | ||
| String APPIUM = "Appium"; | ||
| @Deprecated | ||
| String SELENDROID = "Selendroid"; |
There was a problem hiding this comment.
does it make sense to drop it? (not in this PR, but in general) it was deprecated for a quite long time
There was a problem hiding this comment.
oh yes it does ;)
valfirst
approved these changes
Oct 26, 2021
SrinivasanTarget
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Start adding XCUITest driver options
Types of changes