feat: Add idempotency key to session creation requests #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Mar 31, 2020
SrinivasanTarget
approved these changes
Mar 31, 2020
|
CI is not happy yet since server-side changes aren't available in beta. |
mykola-mokhnach
changed the title
|
@SrinivasanTarget No, unfortunately this is a bug on the server side that is most likely related to keepAlive option and socket reuse. I'll take care about it and restart the test after the patch is merged |
mykola-mokhnach
changed the title
|
All works with the recent base driver patch. cc @KazuCocoa |
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Details
This PR adds a random idempotency key to each session creation request. This is necessary to properly handle HTTP request retries. Read appium/appium-base-driver#400 for more details.