Skip to content

Conversation

saikrishna321
Copy link
Member

Change list

Deprecated Selendroid

http://appium.io/docs/en/drivers/android-selendroid/

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach
Copy link
Contributor

I'd also add @deprecated mention to the docstring containing an explanation what to use instead

@saikrishna321
Copy link
Member Author

@mykola-mokhnach something like this

/**
 * Used to build a complex selendroid locator.
 * @deprecated Use {@link AndroidBy}
 */
@Deprecated
public @interface SelendroidBy {

@mykola-mokhnach
Copy link
Contributor

Please address linter issues

Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just travis to be happy.

@saikrishna321
Copy link
Member Author

I can't find way to fix the linter issue '>=' i'm going to just do greater and equal

@mykola-mokhnach
Copy link
Contributor

replace it with >=

@SrinivasanTarget SrinivasanTarget merged commit 18eba21 into appium:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants