Skip to content

Conversation

valfirst
Copy link
Collaborator

Change list

Use the latest official ECJ 3.14.0

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

The old ECJ reference was bogus (see official confirmation: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499019#c19) and didn't work properly with JDK9


dependencies {
ecj 'org.eclipse.jdt.core.compiler:ecj:4.6.1'
ecj 'org.eclipse.jdt:ecj:3.14.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the whole package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, there are no other options.
In general, I'm not aware of historical reasons of ECJ usage, in theory simple javac can work as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javac cannot compile the solution and SeleniumHQ/selenium#863 is the main reason why it cannot

@mykola-mokhnach
Copy link
Contributor

It looks like Travis is not very happy: https://travis-ci.org/appium/java-client/jobs/430697234

@valfirst
Copy link
Collaborator Author

It looks like some travis issue, similar to this one: travis-ci/travis-ci#3795.

https://travis-ci.org/appium/java-client/jobs/430697234#L817:

attempting to download cache archive
fetching PR.1024/cache-linux-trusty-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--jdk-oraclejdk8.tgz
fetching PR.1024/cache--jdk-oraclejdk8.tgz
fetching master/cache-linux-trusty-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--jdk-oraclejdk8.tgz
running `casher fetch` took longer than 180 seconds and has been aborted.
You can extend the timeout with `cache.timeout`. See https://docs.travis-ci.com/user/caching/#Setting-the-timeout for details

adding /home/travis/.gradle/caches to cache
creating directory /home/travis/.gradle/caches
adding /home/travis/.gradle/wrapper to cache
creating directory /home/travis/.gradle/wrapper
/home/travis/.gradle/wrapper/dists/gradle-4.10.1-all/455itskqi2qtf0v2sja68alqd/gradle-4.10.1-all.zip: Permission denied

I'll touch the commit to trigger a new build

The old ECJ reference was bogus (see official confirmation: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499019#c19) and didn't work properly with JDK9
@mykola-mokhnach mykola-mokhnach merged commit 4c3d5a2 into appium:master Sep 19, 2018
@valfirst valfirst deleted the update-ecj branch July 7, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants