use Duration instead of int for time

Author: titusfortner

src/main/java/io/appium/java_client/remote/MobileOptions.java

@@ -22,6 +22,7 @@
 import org.openqa.selenium.remote.CapabilityType;
 
 import java.net.URL;
+import java.time.Duration;
 import java.util.List;
 
 public class MobileOptions<T extends MobileOptions<T>> extends MutableCapabilities {
@@ -340,7 +341,7 @@ public String getLocale() {
      * @return this MobileOptions, for chaining.
      * @see MobileCapabilityType#NEW_COMMAND_TIMEOUT
      */
-    public T setNewCommandTimeout(int seconds) {
+    public T setNewCommandTimeout(Duration seconds) {
         return amend(MobileCapabilityType.NEW_COMMAND_TIMEOUT, seconds);
     }
 
@@ -350,8 +351,8 @@ public T setNewCommandTimeout(int seconds) {
      * @return timeout before seeing a new command in seconds.
      * @see MobileCapabilityType#NEW_COMMAND_TIMEOUT
      */
-    public int getNewCommandTimeout() {
-        return (int) getCapability(MobileCapabilityType.NEW_COMMAND_TIMEOUT);
+    public Duration getNewCommandTimeout() {
+        return (Duration) getCapability(MobileCapabilityType.NEW_COMMAND_TIMEOUT);
     }
 
     /**

src/test/java/io/appium/java_client/remote/MobileOptionsTest.java

@@ -22,6 +22,7 @@
 
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.time.Duration;
 import java.util.ArrayList;
 
 import static org.junit.Assert.*;
@@ -34,13 +35,13 @@ public void acceptsExistingCapabilities() {
         MutableCapabilities capabilities = new MutableCapabilities();
         capabilities.setCapability("deviceName", "Pixel");
         capabilities.setCapability("platformVersion", "10");
-        capabilities.setCapability("newCommandTimeout", 60);
+        capabilities.setCapability("newCommandTimeout", Duration.ofSeconds(60));
 
         mobileOptions = new MobileOptions<>(capabilities);
 
         assertEquals("Pixel", mobileOptions.getDeviceName());
         assertEquals("10", mobileOptions.getPlatformVersion());
-        assertEquals(60, mobileOptions.getNewCommandTimeout());
+        assertEquals(Duration.ofSeconds(60), mobileOptions.getNewCommandTimeout());
     }
 
     @Test
@@ -56,7 +57,7 @@ public void acceptsMobileCapabilities() throws MalformedURLException {
                 .setLocale("fr_CA")
                 .setUdid("1ae203187fc012g")
                 .setOrientation(ScreenOrientation.LANDSCAPE)
-                .setNewCommandTimeout(60)
+                .setNewCommandTimeout(Duration.ofSeconds(60))
                 .setLanguage("fr");
 
         assertEquals("http://example.com/myapp.apk", mobileOptions.getApp());
@@ -67,7 +68,7 @@ public void acceptsMobileCapabilities() throws MalformedURLException {
         assertEquals("fr_CA", mobileOptions.getLocale());
         assertEquals("1ae203187fc012g", mobileOptions.getUdid());
         assertEquals(ScreenOrientation.LANDSCAPE, mobileOptions.getOrientation());
-        assertEquals(60, mobileOptions.getNewCommandTimeout());
+        assertEquals(Duration.ofSeconds(60), mobileOptions.getNewCommandTimeout());
         assertEquals("fr", mobileOptions.getLanguage());
     }