-
Notifications
You must be signed in to change notification settings - Fork 189
chore: Deprecate legacy app management helpers #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cheers @laolubenson. |
Ideally, we should advise users on how to use the mobile script method |
Yea, a link to appium/appium#15807 may help to see more details. or adding alternative methods as https://github.com/appium/ruby_lib_core/blob/e6bc18853305f5b81c3be8a201ac0f9528e772ea/lib/appium_lib_core/common/device/app_management.rb#L22 also may help. (maybe the github link should be sufficient) |
@KazuCocoa, @laolubenson I've improved the deprecation messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Change list
As mentioned in appium/appium#15807, these methods will not be supported anymore.
Related item:
#562
For now, I updated only one Integration test to use the more standard Appium session management, more will follow.
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
x
in the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub