feat: activate app with timeout #579
Conversation
|
|
|
@Dor-bl Please note that the CLA was already signed before, I don't know why it does not update. |
|
From where did you created the PR? |
|
@Dor-bl I used the same user, created a fork merge request using github. (same as I did before) |
This reverts commit 893d0e1.
agentran
force-pushed
the
release/5.0.0
branch
from
c4e383d to
1d98df7
Compare
|
@Dor-bl Resolved. |
|
hey @Dor-bl, can we please approve this pr? |
|
Sure, just you have one open review. Once you replay I will approve |
|
which review is open? |
|
This one #579 (comment) |
|
hey @Dor-bl |
|
@agentran can you open a new issue for the test suite that is not working for iOS? |
| public void CanActivateAppWithTimeoutTest() | ||
| { | ||
| //Activate an app to foreground | ||
| Assert.DoesNotThrow(() => _driver.ActivateApp(IosTestAppBundleId, TimeSpan.FromSeconds(20))); |
There was a problem hiding this comment.
BTW @agentran , did you checked that iosTeatAppBudleId works? i have no access to ios simulator currently.
There was a problem hiding this comment.
@agentran please refer to this before I approve the PR
There was a problem hiding this comment.
@agentran will be handled on a separate PR to fix iOS AppTests.
2 participants
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub