Skip to content

Conversation

TroyWalshProf
Copy link
Contributor

Drop OS specific element types

Change list

Drop all FindElementBy* and FindElementsBy* calls.
Stop using driver specific web elements.
Stop requiring web element type to be names for each driver.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Drop all FindElementBy* and FindElementsBy* calls.
Stop using driver specific web elements.
Stop requiring web element type to be names for each driver.

Drop OS specific element types
Copy link

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. It would also be nice to change the description of the PR according to https://www.conventionalcommits.org/en/v1.0.0/ rules

@TroyWalshProf TroyWalshProf changed the title Drop FindElementBy* and FindElementsBy* chore: drop FindElementBy* and FindElementsBy* Oct 17, 2021
@TroyWalshProf TroyWalshProf marked this pull request as ready for review October 17, 2021 14:40
@laolubenson
Copy link
Collaborator

@TroyWalshProf are you still making changes to this branch?

@TroyWalshProf
Copy link
Contributor Author

@akinsolb - I am done with the PR

@laolubenson laolubenson merged commit 9565e57 into appium:release/5.0.0 Oct 18, 2021
@grishukov
Copy link

@TroyWalshProf @akinsolb
Hi! So since 5.0 beta we should use AppiumElements and strings for locators methods like xpaths, ids etc
somthing like that?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants