Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor in preparation for session file handling changes #1646

Merged
merged 4 commits into from
Sep 3, 2024
Merged

chore: refactor in preparation for session file handling changes #1646

merged 4 commits into from
Sep 3, 2024

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Sep 3, 2024

This is a small refactor in preparation for adjustments to session file handling. These adjustments are already made in a separate branch, but the branch includes too many changes that could be extracted, therefore I made this PR.
Changes made:

  • Adjust Electron IPC calls to include scope (basically just replace - with :)
  • Rename redux event SET_STATE_FROM_SAVED to SET_STATE_FROM_FILE
  • Add a dedicated constant for the types that a capability value can take
  • Move file handler util methods from other.js to a new file-handling.js file

@github-actions github-actions bot added the chore Internal changes not visible to the user label Sep 3, 2024
@eglitise eglitise merged commit d73da52 into appium:main Sep 3, 2024
6 checks passed
@eglitise eglitise deleted the refactor-for-session-files branch September 3, 2024 16:12
jlipps
jlipps reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
@eglitise
chore: refactor in preparation for session file handling changes (app…
f35e593 
…ium#1646)

* chore: use scope for electron IPC calls

* chore: rename redux event

* chore: add const for capability types

* chore: move file handler utils to separate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps left review comments

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@mykola-mokhnach mykola-mokhnach Awaiting requested review from mykola-mokhnach

Assignees
No one assigned
Labels
chore Internal changes not visible to the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eglitise @jlipps @KazuCocoa