fix: Use monitoredApplicationWithProcessIdentifier API to fetch application objects from PID #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation objects from PID
KazuCocoa
approved these changes
Sep 22, 2023
Dan-Maor
reviewed
Sep 22, 2023
| @@ -23,15 +23,6 @@ | |||
|
|
|||
| @implementation XCUIApplication (FBCompatibility) | |||
|
|
|||
| + (instancetype)fb_applicationWithPID:(pid_t)processID | |||
| { | |||
| if (0 == processID) { | |||
There was a problem hiding this comment.
Are you sure this protection is not needed? What happens if the requested pid is 0?
Maybe then try to add logs after each line in the fb_activeApplicationWithDefaultBundleId method to precisely isolate the particular API call that creates the delay. Then we may try to find alternatives to it or find out what exactly creates the delay |
|
I am not 100% convinced to merge this PR especially taking into account it does not fix the original issue related to testmanagerd crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #774