Skip to content

Fix for issue# 2857 on connect-app #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akumar1503
Copy link

  • Bottom link is now clickable in WizardRight.
  • Continue button fix in RegistrationScreen, it's not required to click the "I agree to receive other communications from Topcoder." checkbox.
  • removed + sign requirement in phone numbers in Formsy.PhoneInput.

…egistrationScreen and remove + sign requirement in phone numbers in Formsy.PhoneInput
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works good @akumar1503 .

Only one thing, could you please return adding + when we choose the county code in the dropdown.
We don't require entering + by users, but we still want to add + when we choose the country code.

@akumar1503
Copy link
Author

@maxceem done.

@akumar1503
Copy link
Author

added minor correction, done now.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

Thank you @akumar1503

@maxceem
Copy link
Collaborator

maxceem commented Feb 28, 2019

@RishiRajSahu I've tested this PR to cover 3 issues listed here appirio-tech/connect-app#2857

It works good for me.
It can be merged separately from changes in Connect app.

@RishiRajSahu RishiRajSahu merged commit 4389bfe into appirio-tech:feature/connectv2 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants