AndroidX migration. #12
Conversation
There was a problem hiding this comment.
First of all, thank you for contributing to this repository! TBH, I thought it doesn't work anymore 😄
I left a couple of comments/questions, but there's a big one coming...
Would you be able to target the latest SDK level (and verify the app works)? Assuming that I can find the signing key for this project, Google Play will not allow us to publish an update unless we target the latest SDK.
| } | ||
|
|
||
| private String generatePhoneNumber() { | ||
| Random rndGenerator = new Random(); |
There was a problem hiding this comment.
There's already a rndPhoneTypeGenerator which can be a generic random generator. There's no security concern with this app, I believe we can just reuse it 🙂
| closeable.close(); | ||
| } catch (Exception e) { | ||
| Log.w(TAG, "Cannot close the closeable " + String.valueOf(closeable)); | ||
| Log.w(TAG, "Cannot close the closeable " + closeable); |
There was a problem hiding this comment.
We had String.valueOf() calls to explicitly convert null values into "null" (string value of 4 chars).
Why do you think it's not necessary anymore?
|
|
||
| private void showNotification() { | ||
| mBuilder = new NotificationCompat.Builder(this); | ||
| mBuilder = new NotificationCompat.Builder(this, CONTACTS_GENERATOR_CHANNEL); |
2 participants
No description provided.