Merge branch 'stage' into ADFA-2878-detect-git-repo

Author: dara-abijo-adfa

app/src/main/java/com/itsaky/androidide/actions/etc/DisconnectLogSendersAction.kt

@@ -23,6 +23,7 @@ import com.itsaky.androidide.R
 import com.itsaky.androidide.actions.ActionData
 import com.itsaky.androidide.actions.EditorActivityAction
 import com.itsaky.androidide.actions.markInvisible
+import com.itsaky.androidide.idetooltips.TooltipTag
 import com.itsaky.androidide.services.log.lookupLogService
 
 /**
@@ -33,6 +34,7 @@ import com.itsaky.androidide.services.log.lookupLogService
 class DisconnectLogSendersAction(context: Context, override val order: Int) : EditorActivityAction() {
 
   override val id: String = "ide.editor.service.logreceiver.disconnectSenders"
+    override fun retrieveTooltipTag(isReadOnlyContext: Boolean): String = TooltipTag.EDITOR_TOOLBAR_LOG_SENDER
 
   init {
     label = context.getString(R.string.title_disconnect_log_senders)

app/src/main/java/com/itsaky/androidide/app/IDEApplication.kt

@@ -184,16 +184,24 @@ class IDEApplication : BaseApplication() {
 		thread: Thread,
 		exception: Throwable,
 	) {
+		if (isNonFatalGcCleanupFailure(exception)) {
+			logger.warn("Non-fatal: ZipFile GC cleanup failed with I/O error", exception)
+			return
+		}
+
 		if (isUserUnlocked) {
-			// we can access credential protected storage, delegate the job to
-			// to advanced crash handler
 			CredentialProtectedApplicationLoader.handleUncaughtException(thread, exception)
 			return
 		}
 
-		// we can only access device-protected storage, and are not allowed
-		// to show crash handler screen
-		// delegate the job to the basic crash handler
 		DeviceProtectedApplicationLoader.handleUncaughtException(thread, exception)
 	}
+
+	private fun isNonFatalGcCleanupFailure(exception: Throwable): Boolean {
+		if (exception !is java.io.UncheckedIOException) return false
+		return exception.stackTrace.any {
+			it.className.contains("CleanableResource") ||
+				it.className.contains("PhantomCleanable")
+		}
+	}
 }

idetooltips/src/main/java/com/itsaky/androidide/idetooltips/TooltipTag.kt

@@ -93,6 +93,7 @@ object TooltipTag {
     const val EDITOR_TOOLBAR_QUICK_SAVE = "project.save"
     const val EDITOR_TOOLBAR_PREVIEW_LAYOUT = "editor.layout.preview"
     const val EDITOR_TOOLBAR_COMPUTER_VISION = "project.layout.vision"
+    const val EDITOR_TOOLBAR_LOG_SENDER = "editor.disconnect.logsenders"
 
     // Delete project
     const val DELETE_PROJECT = "project.delete"

subprojects/javac-services/src/main/java/com/itsaky/androidide/javac/services/fs/CachedJarFileSystem.kt

@@ -47,6 +47,7 @@ class CachedJarFileSystem(
     // This is called manually by the Java LSP
   }
 
+  @Throws(IOException::class)
   fun doClose() {
     try {
       super.close()