Explicitly destroy the HTTPClientSession after it's finished.

Martin Robinson · Martin Robinson · commit 7bfe3f87bbe8 · 2009-10-13T11:00:18.000-07:00
Even if KJS doesn't garbage collect open HTTPClient, at least their
HTTPClientSession's will not hang about with open sockets.
diff --git a/modules/ti.Network/http/http_client_binding.cpp b/modules/ti.Network/http/http_client_binding.cpp
@@ -798,6 +798,10 @@ namespace ti
 			this->FireEvent(Event::HTTP_TIMEOUT);
 		}
 
+		// Destroy the session here, so that even if this HTTPClient isn't
+		// garbage collected, the socket will close.
+		this->session = 0;
+
 		this->Set("connected", Value::NewBool(false));
 		this->ChangeState(4); // closed
 	}

Original file line number	Diff line number	Diff line change
`@@ -798,6 +798,10 @@ namespace ti`
`798`	`798`	`this->FireEvent(Event::HTTP_TIMEOUT);`
`799`	`799`	`}`
`800`	`800`
	`801`	`+ // Destroy the session here, so that even if this HTTPClient isn't`
	`802`	`+ // garbage collected, the socket will close.`
	`803`	`+ this->session = 0;`
	`804`	`+`
`801`	`805`	`this->Set("connected", Value::NewBool(false));`
`802`	`806`	`this->ChangeState(4); // closed`
`803`	`807`	`}`