Dispatch errors from the primary response to deferred responses #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
the deferred node's path now contains fragments to help in query reconstruction, and the flatten elements are not present anymore
Geal
force-pushed
the
geal/dispatch-errors-from-primary
branch
2 times, most recently
from
456e91d
to
45f839c
Compare
Geal
changed the title
like errors, they should be assigned to the relevant incremental response
if a primary and deferred query were both generated from a single subgraph call, the errors should be sent to the deferred node as well, because they might be related to the deferred response
an error path might affect a part of the response that is not available anymore. We have to check if that error belongs to the primary query or any of the deferred queries to dispatch the error to the corresponding response
Geal
force-pushed
the
geal/dispatch-errors-from-primary
branch
from
2c6d4e5
to
d564e36
Compare
Geal
commented
Dec 12, 2022
| @@ -23,24 +23,6 @@ expression: stream.next_response().await.unwrap() | |||
| "suborga", | |||
| 0 | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
this is removing the redundant parts of the snapshot, now that error dispatching is fixed
BrynCooke
approved these changes
Dec 12, 2022
o0Ignition0o
approved these changes
Dec 12, 2022
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
lint update licenses
Geal
force-pushed
the
geal/dispatch-errors-from-primary
branch
from
f2cc4e3
to
60a3b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1818
Fix #2185
Blocked by #2109 (waiting for the router-bridge update)
When errors are generated during the primary execution, some of them can be affected to
deferred responses.
To handle that, we need to:
Since the error path may belong to a part of the response that was nullified, we need to follow the error path through the primary or deferred queries