Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporter port default does not match tonic vs http #5717

Open
BrynCooke opened this issue Jul 24, 2024 · 1 comment
Open

OTLP exporter port default does not match tonic vs http #5717

BrynCooke opened this issue Jul 24, 2024 · 1 comment

Comments

@BrynCooke
Copy link
Contributor

It looks like Otel does not switch the exdpoint based on if tonic or http builders are used. Instead it is statically determined by feature gate.

This means that anyone who doesn't explicitly specify the endpoint is going to run into trouble.

Worse still, the defaults don't work.
So whereas users should just be able to set:

    metrics:
      otlp:
        temporality: delta
        enabled: true

It will actually choose the wrong default port of 3218 which is for use with grpc.

To fix we need to explicitly default the endpoints of otlp rather than relying on otel to do this defaulting.

@Geal
Copy link
Contributor

Geal commented Jul 29, 2024

We need to communicate in the changelog that this is potentially breaking, if customers changed their collection services to the wrong default port of the router (unlikely, but still possible)

@Geal Geal added the bug label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants