Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust hashing of header list for caches #462

Open
Geal opened this issue Feb 14, 2022 · 1 comment
Open

robust hashing of header list for caches #462

Geal opened this issue Feb 14, 2022 · 1 comment
Assignees
Labels
enhancement An enhancement to an existing feature

Comments

@Geal
Copy link
Contributor

Geal commented Feb 14, 2022

follow-up on #285 (comment)

the query deduplication PR #285 hashes all the headers in the order they are provided, which could result in duplication if multiple similar queries come with headers in a different order. As @garypen said, we could define an order for hashing the headers, which would allow deduplicating more queries

@Geal Geal added the triage label Feb 14, 2022
@abernix abernix removed the triage label May 23, 2022
@abernix abernix added the enhancement An enhancement to an existing feature label Oct 24, 2022
@Geal
Copy link
Contributor Author

Geal commented Apr 7, 2023

while we are here, we should make the deduplication configurable. ie hashing on some headers but not other ones, depend on the authorization status, etc

@Geal Geal self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants