Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: What do we want to measure and how #29

Closed
o0Ignition0o opened this issue Oct 28, 2021 · 3 comments
Closed

Tracing: What do we want to measure and how #29

o0Ignition0o opened this issue Oct 28, 2021 · 3 comments
Assignees

Comments

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Oct 28, 2021

Followup to a comment, now that we have stable tracing we might wanna sit back and figure out what we would like to trace, and at what level.

IMO this calls for a group discussion, I hope this issue provide such a space.

Do we really need to measure so much? @BrynCooke any opinion on this?

@Geal
Copy link
Contributor

Geal commented Oct 29, 2021

I think we should measure a lot. We are still learning how this software works, so we need to see clearly its internal behaviour to build a good mental model. This may not be the case later, when we're more confident and know which measurements are really useful.
In the meantime, we can reduce the amount of data by carefully setting the log levels (keeping debug or trace for our usage) and sampling traces. Example: sending all traces for failing queries, but 1 in 10 successful queries, because the successful ones are less interesting and the common case

@o0Ignition0o o0Ignition0o transferred this issue from another repository Nov 4, 2021
@Geal Geal mentioned this issue Dec 1, 2021
@abernix
Copy link
Member

abernix commented Mar 22, 2022

This issue is getting a bit stale at this point and i'm not sure if we have anything actionable on it today, particularly given that we've done a lot of measuring (over measuring, in a lot of cases!) in our tracing and have observed — in most cases —  the performance and verbosity implications of doing so.

Do we want to do anything else with this right now, concretely?

@o0Ignition0o
Copy link
Contributor Author

I don't think we do, we have changed this quite a bit over time, so i m closing this.

Happy to reopen later if needs be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants