Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass resolver arguments in asyncIteratorFactory #102

Closed
stalniy opened this issue Sep 10, 2017 · 2 comments
Closed

Pass resolver arguments in asyncIteratorFactory #102

stalniy opened this issue Sep 10, 2017 · 2 comments

Comments

@stalniy
Copy link

stalniy commented Sep 10, 2017 •
edited
Loading

Issue:
I store my PubSub instance in Graphql context variable, so when using withFilter I can't access to it and return asyncIterator instance.

Possible solution:
I suggest to pass all resolvers arguments into asyncIterator factory function, so then I can read PubSub instance from context.

The fix is trivial, just to change a line of code. So, if you are ok with this I will make a PR
@srtucker22
Copy link
Contributor

I was just running into the same thing and threw together #103 😃

@NeoPhi
Copy link
Contributor

NeoPhi commented Sep 19, 2017

Closed via https://github.com/apollographql/graphql-subscriptions/releases/tag/v0.5.1

@NeoPhi NeoPhi closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NeoPhi @stalniy @srtucker22