fix(composition): Catch unsatisfiable @shareable mutation fields
#3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31be1e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Docs preview failedThe preview failed to build. Build ID: 599fc1b1f80a53dd41735724 ErrorsGeneral: ENOSPC: no space left on device, mkdir '/tmp/librarian/remote-sources/apollographql/rover/main' |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
force-pushed
the
sachin/fix-shareable-mutation-fields-in-composition
branch
from
17ed572 to
bda02c8
Compare
sachindshinde
force-pushed
the
sachin/fix-shareable-mutation-fields-in-qp
branch
from
369029b to
57c8040
Compare
sachindshinde
force-pushed
the
sachin/fix-shareable-mutation-fields-in-composition
branch
from
bda02c8 to
31be1e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where composition may erroneously declare a schema with a
@shareablemutation field satisfiable when it shouldn't be.Specifically, this PR updates composition satisfiability to ensure that all query paths under a
@shareablemutation field can be satisfied starting at the same subgraph. (I.e., that no matter what selection set is on the@shareablemutation field, the query planner will not need to make multiple calls to that mutation field across subgraphs.)This is done by partitioning subgraph paths in
ValidationStateby the initial subgraph when a shared mutation field is encountered, and keeping track of separate error stacks as well. If all these partitions experience satisfiability errors, then there's no way to satisfy the selection set containing the witness operation from each partition using a single@shareablemutation field call, and the user is asked to fix (at least) one of the partition's satisfiability errors.This PR may cause composition errors for a previously successful composition if that composition was mistakenly satisfiable due to this bug. We've determined that this may not be a rare occurrence, and accordingly this fix will land in the next minor release (which is why this PR was split off from #3303, where it was originally filed). This PR is currently stacked on top of #3304 for tests to pass, but once that PR merges and is pulled into
next, this PR's base will change tonext.