fix(federation): Composition propagates @deprecated usages on input type object fields #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
approved these changes
Sep 8, 2021
Member
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
LGTM assuming you introduce a CHANGELOG.md!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #996
In landing #996, @sachindshinde discovered that
@deprecatedpropagation failed specifically for fields on input type objects.We discovered this was an issue in
graphql-jsitself which has since been landed and released inv15.5.3graphql/graphql-js#3260
This PR pushes our
graphqlpeerDependenciestolatestand as such is a breaking change for gateway users, requiring a (relatively small) update to their project'sgraphqldependency from15.4.0.This is a breaking change for the federation, query-planner, and gateway packages and should be landed to a release branch.
TODO