Fix required fields regression

[mattbretl]

TODO:

• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests pass
• Update CHANGELOG.md with your change
• If this was a change that affects the external API, update the README

Fixes a regression of #63 introduced in v3.0.0

[benjie]

Can confirm that I have this issue too, and that Matt's fix (applied directly to node_modules) fixes it for me. The error is then caught by graphql/template-strings

Note it only wraps the code in an if block - use ?w=1 to ignore whitespace changes.

[abernix]

This LGTM to me with one nitty, formatting-related comment below, but a slight question as to whether or not this was intentional or not.

It looks like this was removed in 6886c0f#diff-95dbafa783634330b4c1ec80e94c9964L34.

@stubailo Do you have any recollection of a specific reason the if (!def) conditional might have been removed in the above commit?

[abernix]

Rather than indent entire block to encapsulate it with this if conditional, would it be possible to opt for the behavior that was here before which returned when def wasn't truthy?:

eslint-plugin-graphql/src/customGraphQLValidationRules.js

Lines 34 to 36 in f1331d2

	if (!def) {
	return;
	}

(In general, reducing over-indentation seems like a good principle to maintain.)

[abernix]

LGTM.

[abernix]

Thanks for opening this PR! I made a couple of formatting changes, but this has now landed in eslint-plugin-graphql@3.0.2.