Commit 312a7c1
committed
Disable file-upload tests on Node.js 14.
Node.js 14 is not LTS yet, but we want to make sure that we're preparing
for and breaking changes that it brings.
We can't support uploads on Node.js 14 before we upgrade to `graphql-upload`
version 10, which is a major breaking change for current upload users.
We're very aware (via issues like
#3508) that we won't
support it on Node.js 14 without updating it to a newer version.
In a conflicting vein though, we're actually removing `graphql-upload` from
Apollo Server 3.x (and letting the package be usable by itself), so this
just allows us to test the rest of our stack which we intend to support on
Node.js 14, while recognizing that we're not intending on supporting uploads
as a built-in.1 parent b90b46c commit 312a7c1
File tree
5 files changed
+18
-15
lines changed- packages
- apollo-server-express/src/__tests__
- apollo-server-fastify/src/__tests__
- apollo-server-koa/src/__tests__
- apollo-server-lambda/src/__tests__
- apollo-server-micro/src/__tests__
5 files changed
+18
-15
lines changedLines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
483 | | - | |
484 | | - | |
485 | | - | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
486 | 486 | | |
487 | 487 | | |
488 | 488 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
445 | | - | |
446 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
346 | | - | |
347 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
110 | 109 | | |
111 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
112 | 115 | | |
113 | 116 | | |
114 | 117 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| |||
0 commit comments