Skip to content

Commit 1dd45b8

Browse files
committed
get CI passing
1 parent d38b43b commit 1dd45b8

File tree

7 files changed

+222
-140
lines changed

7 files changed

+222
-140
lines changed

.circleci/config.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,25 @@ commands:
1616
# something different. Probably best to avoid that, out of principle, though.
1717
common_node_steps:
1818
description: "Set up Node.js environment and install dependencies"
19+
parameters:
20+
npm_version:
21+
default: '8'
22+
type: string
1923
steps:
2024
- oss/install_specific_npm_version:
21-
version: '8'
25+
version: <<parameters.npm_version>>
2226
- checkout
2327
- oss/npm_clean_install_with_caching
2428

2529
common_test_steps:
2630
description: "Set up Node.js environment and run tests"
31+
parameters:
32+
npm_version:
33+
default: '8'
34+
type: string
2735
steps:
28-
- common_node_steps
36+
- common_node_steps:
37+
npm_version: <<parameters.npm_version>>
2938
- run:
3039
command: npm run test:ci
3140
environment:
@@ -47,7 +56,8 @@ jobs:
4756
docker:
4857
- image: cimg/node:12.22.6
4958
steps:
50-
- common_test_steps
59+
- common_test_steps:
60+
npm_version: '6'
5161
# We will save the results of this one particular invocation to use in
5262
# the publish step. Not only does this make the publishing step take less
5363
# time, this also ensures that a passing version gets deployed even if,
@@ -66,7 +76,7 @@ jobs:
6676

6777
NodeJS 16:
6878
docker:
69-
- image: cimg/node:16.10.0
79+
- image: cimg/node:16.20
7080
steps:
7181
- common_test_steps
7282

@@ -78,14 +88,14 @@ jobs:
7888

7989
Prettier:
8090
docker:
81-
- image: cimg/node:16.10.0
91+
- image: cimg/node:16.20
8292
steps:
8393
- common_node_steps
8494
- run: npm run prettier-check
8595

8696
Spell check:
8797
docker:
88-
- image: cimg/node:16.10.0
98+
- image: cimg/node:16.20
8999
steps:
90100
- common_node_steps
91101
- run: npm run spell-check
@@ -131,7 +141,6 @@ common_publish_filters: &common_publish_filters
131141
ignore: /.*/
132142

133143
workflows:
134-
version: 2
135144
Build:
136145
jobs:
137146
- NodeJS 12:

cspell-dict.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ automerge
1414
Automerge
1515
automerges
1616
backoff
17+
barbaz
1718
beyoncé
1819
blahblah
1920
Blocklist

0 commit comments

Comments
 (0)