OPERATION_BASED_WITH_INTERFACES fragment's name clash

[chalermpong]

Summary

With experimental_operationBasedWithInterfaces codegen model, fragment's name clash can happen with the example below. This problem is also exist in responseBased codegen model.

Version

3.6.1-SNAPSHOT

Steps to reproduce the behavior

Use this graphql:

query TestOperation {
  animal {
    ... AnimalFragment
  }
}
fragment AnimalFragment on Animal {
  species
  ... on Lion {
    ... LionAnimalFragment
  }
}
fragment LionAnimalFragment on Lion {
  temperature
}

For experimental_operationBasedWithInterfaces, output code will have two LionAnimalFragment classes:

// From typeset model for AnimalFragment
public data class LionAnimalFragment(
  public override val __typename: String,
  public override val species: String,
  /**
   * Synthetic field for inline fragment on Lion
   */
  public override val onLion: AnimalFragment.OnLion,
) : AnimalFragment

// From LionAnimalFragment
public data class LionAnimalFragment(
  public val temperature: Int,
) : Fragment.Data

For responseBased, output code will have two LionAnimalFragment:

public interface LionAnimalFragment : AnimalFragment, LionAnimalFragment {
  public override val __typename: String

  public override val species: String

  public override val temperature: Int
}

public interface LionAnimalFragment {
  public val temperature: Int
}

[martinbonnin]

Good catch. We could nest the fragment classes in their interface (which is guaranteed to be unique because we don't allow 2 fragments with the same name)

interface AnimalFragment {
  class LionAnimalFragment: AnimalFragment
}

interface LionAnimalFragment

But that's a breaking change so for now I'd recommend to rename the fragment if that ever happens.