Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to test cache key generation with JSON objects #1304

Open
designatednerd opened this issue Jul 8, 2020 · 1 comment
Open

Figure out how to test cache key generation with JSON objects #1304

designatednerd opened this issue Jul 8, 2020 · 1 comment
Labels
caching testing

Comments

@designatednerd
Copy link
Contributor

#1281 addresses an issue where cache keys were being unstably generated when one of the items was a JSON array. I haven't been able to find an API that takes JSON arrays, so we need to find an alternate method of testing key generation for this. Don't want to hold up an actual fix for the issue until I can figure this out, so making this issue to come back to it.
@designatednerd designatednerd mentioned this issue Jul 8, 2020
Merged
@designatednerd designatednerd mentioned this issue Mar 4, 2021
Open
13 tasks
@AnthonyMDev
Copy link
Contributor

This is doable now using the MockSelectionSet test infra. See FetchQueryTests for examples. I need to actually go back and write these tests as some point though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
caching testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@calvincestari @designatednerd @AnthonyMDev