Improve error description formatting for validation failure #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of printing a literal array (brackets and all!) of errors, print each error on its own indented line.
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
calvincestari
approved these changes
Nov 20, 2025
Member
calvincestari
left a comment
calvincestari
left a comment
There was a problem hiding this comment.
Thanks for the improvement @dfed.
Member
|
I'm going to merge this even with the failed CI test because these changes don't affect that and it's been fixed in #849. |
BobaFetters
pushed a commit
that referenced
this pull request
Nov 20, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 20, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Nov 20, 2025
7e754865b Improve error description formatting for validation failure (#846) git-subtree-dir: apollo-ios-codegen git-subtree-split: 7e754865ba8f7ebde21a99eb4ea222df8f5c2f54
BobaFetters
pushed a commit
that referenced
this pull request
Nov 20, 2025
…tting for validation failure git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 42c0c1b git-subtree-split: 7e754865ba8f7ebde21a99eb4ea222df8f5c2f54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing a literal array (brackets and all!) of errors, print each error on its own indented line.