-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Reduce Generated Schema Types #601
Conversation
Adds a new codegen configuration option to reduce the number of Object types that are generated so that only types that are referenced in an operation document or have a @typePolicy will be generated, instead of generating all types that implement a referenced Interface.
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: 645a0c84658797a04f471acd URL: https://www.apollographql.com/docs/deploy-preview/645a0c84658797a04f471acd |
✅ Deploy Preview for apollo-ios-docc canceled.
|
...o-ios-codegen/Sources/ApolloCodegenLib/CodegenConfiguration/ApolloCodegenConfiguration.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments. This looks really good!
apollo-ios-codegen/Sources/GraphQLCompiler/GraphQLJSFrontend.swift
Outdated
Show resolved
Hide resolved
...o-ios-codegen/Sources/ApolloCodegenLib/CodegenConfiguration/ApolloCodegenConfiguration.swift
Outdated
Show resolved
Hide resolved
...o-ios-codegen/Sources/ApolloCodegenLib/CodegenConfiguration/ApolloCodegenConfiguration.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about a property on Object
, looks good otherwise.
...o-ios-codegen/Sources/ApolloCodegenLib/CodegenConfiguration/ApolloCodegenConfiguration.swift
Show resolved
Hide resolved
d819a576 feature: Reduce Generated Schema Types (#601) 81bb93a7 Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: d819a5764124feb5ae4bc1f93b673b6267fa0cac
git-subtree-dir: apollo-ios git-subtree-mainline: 1d81901 git-subtree-split: d819a5764124feb5ae4bc1f93b673b6267fa0cac
d689a45f feature: Reduce Generated Schema Types (#601) git-subtree-dir: apollo-ios-codegen git-subtree-split: d689a45f6ddd527fc77d8f62a7f2f0ad66b8d2f7
…a Types git-subtree-dir: apollo-ios-codegen git-subtree-mainline: c383a3d git-subtree-split: d689a45f6ddd527fc77d8f62a7f2f0ad66b8d2f7
Adds a new codegen configuration option to reduce the number of Object types that are generated so that only types that are referenced in an operation document or have a @typePolicy will be generated, instead of generating all types that implement a referenced Interface.
Closes apollographql/apollo-ios#3505