fix: abort stale connection on reobserve (#9532) #9791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-garcia-meteologica
force-pushed
the
fix_abort_stale_connection_reobserve
branch
3 times, most recently
from
54dae34 to
4881f03
Compare
|
@javier-garcia-meteologica Thank you for contribution, could you give us a little more detail of what you are submitting this PR? |
|
@jpvajda I've added a description to this PR, which I had previously forgotten. |
benjamn
force-pushed
the
fix_abort_stale_connection_reobserve
branch
from
eadf0b6 to
182b3e7
Compare
benjamn
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Thanks for fixing (and testing) this @javier-garcia-meteologica!
| this.concast.removeObserver(this.observer, true); | ||
| this.concast.removeObserver(this.observer); |
There was a problem hiding this comment.
We've been testing this change in the v3.7 betas thanks to #9718, with no problems so far.
benjamn
added
🧞 fixed-by-contributor
|
@javier-garcia-meteologica These changes have been soft-published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sure that after a ObservableQuery is reboserved (e.g. variables are changed), it unsubscribes from stale connections (those using old variables) so they can be cancelled by the browser.
Problem example: Use
watchQuerywith an interactivesearchValueas input. When the user types too fast and the query take longer than the debounce limit (300ms), apollo client makes new connections to the bakend with the newsearchValue. However old connections, which are a burden to the backend, are not aborted.Fixes #9532
Checklist: