Improvements to asyncMap Observable utility function. #7818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might help with #7806, since `asyncMap` is in the stack trace.
jcreighton
approved these changes
Mar 10, 2021
benjamn
force-pushed
the
catch-asyncMap-next-exceptions
branch
from
162115c
to
d218764
Compare
benjamn
changed the title
This was referenced Mar 15, 2021
Merged
This was referenced Mar 16, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might help with #7806, based on the presence of
asyncMapin the stack trace.@SubZane If you have a chance to try hacking this change into your app's version of
asyncMap, I'd be curious to know if it helps catch/handle the error (rather than letting it become an unhandled rejection).