Merge mutation variables from base options and function invocation #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannn
commented
Aug 28, 2020
| /** | ||
| * Merges the provided objects shallowly and removes | ||
| * all properties with an `undefined` value | ||
| */ |
There was a problem hiding this comment.
I added this comment for clarity.
amannn
commented
Aug 28, 2020
| }, | ||
| result: { data: expectedData }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
This test actually detected the behaviour for HOCs. Since this is now fixed, I'v adapted the test.
I also added another test specifically for the hooks version.
|
@amannn we're definitely considering this PR, thanks very much for working on it! We'll post back with an update shortly. |
|
@hwillson That's great, thanks! |
|
@benjamn Thank you for your help! |
amannn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)Fixes #6619