react and graphql-tag dependency adjustments
#5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to re-export `gql`, making it part of the `@apollo/client` bundle, to pave the way for future optimizations (that will require `gql` being part of core). Note: Due to the way `graphql-tag` is bundled, we have to follow Rollup's recommendations listed at https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module to be able to include it in the `@apollo/client` bundle.
benjamn
reviewed
Oct 15, 2019
There was a problem hiding this comment.
Looks good, but we need to include graphql-tag in the globals map in config/rollup.config.js to avoid re-bundling graphql-tag into the @apollo/client bundle(s), which is what caused the bundle size to spike so dramatically. I'll push a commit to fix that in a moment.
benjamn
approved these changes
Oct 15, 2019
SimenB
reviewed
Oct 16, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
reactan optional dependency (since@apollo/client's React integration can be removed using tree-shaking / dead code elimination)graphql-taga full dependency, and re-exportsgqlmaking it part of the default@apollo/clientbundle (to pave the way for futuregqloptimizations)gqlfrom@apollo/client