Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert LF fix to uncorrupt images in documentation #4438

Merged
merged 5 commits into from
Feb 20, 2019

Conversation

rajington
Copy link
Contributor

#4232 accidentally corrupted some pngs, this reverts them ignoring one that was deleted

the fix in apollographql#4232 accidentally corrupted the pngs, this reverts them
it ignores one that was deleted
@apollo-cla
Copy link

@rajington: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@rajington rajington changed the title Revert LF fix for pngs Revert LF fix to uncorrupt images in documentation Feb 13, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @rajington - thanks very much!

Without this, git tries to adjust the line feed for binary
files as well.
@hwillson
Copy link
Member

Looks like the missing =auto from the .gitattributes was causing this. Great find @rajington - thanks again!

@hwillson hwillson merged commit 0bfba30 into apollographql:master Feb 20, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants