Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QueryKeyMaker abstraction. #4245

Merged
merged 1 commit into from
Dec 18, 2018

Commits on Dec 17, 2018

  1. Remove QueryKeyMaker abstraction.

    It's nice to be able to assume that (sub)queries with equivalent structure
    share the same object identities, but the cache will work without that
    assumption, and enforcing that discipline is not free, both in terms of
    runtime cost and in terms of bundle size.
    
    In the future, the `graphql-tag` tag package should provide a version of
    the `gql` template tag function that returns immutable structures that
    share object identity where possible.
    
    This commit alone saves 450ish bytes after minification and gzip!
    benjamn committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    fa9b281 View commit details
    Browse the repository at this point in the history