Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace forceFetch by fetchPolicy #4140

Merged
merged 2 commits into from
Jan 2, 2019

Conversation

Caerbannog
Copy link
Contributor

The docs for ssrForceFetchDelay refer to a forceFetch config of apollo-client that seems to have been replaced by a fetchPolicy config.

Here is the line where ssrForceFetchDelay influences the refetch process:
https://github.com/apollographql/apollo-client/blob/d02a842/packages/apollo-client/src/ApolloClient.ts#L227

Another page that probably needs to be updated: https://www.apollographql.com/docs/angular/recipes/server-side-rendering.html#store-rehydration

The docs for `ssrForceFetchDelay` refer to a `forceFetch` config of apollo-client that seems to have been replaced by a `fetchPolicy` config.

Here is the line where `ssrForceFetchDelay` influences the refetch process:
https://github.com/apollographql/apollo-client/blob/d02a842/packages/apollo-client/src/ApolloClient.ts#L227

Another page that probably needs to be updated: https://www.apollographql.com/docs/angular/recipes/server-side-rendering.html#store-rehydration
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @Caerbannog - thanks!

@hwillson hwillson merged commit 0ffa69a into apollographql:master Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants