Fix issue where no-cache fetch policy causes empty query results
#3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `QueryManager.getCurrentQueryResult` is called, it first tries to get the current data from a `newData` property stored alongside a previously created query (using `getQuery`). If data can't be found, it then tries to load data from the cache. When a `no-cache` fetch policy is used however, the `newData` property is being improperly removed before `getCurrentQueryResult` has a chance to get it. Then when it tries to fallback on loading data from the cache, it finds no matching data, since the `no-cache` fetch policy means the cache isn't being used. This commit adjusts `QueryManager.queryListenerForObserver` such that is doesn't remove the `newData` that is stored with a query, if a `no-cache` fetch policy is being used. This allows `QueryManager.getCurrentQueryResult` to return the loaded `no-cache` data.
Generated by 🚫 dangerJS |
This was referenced Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
QueryManager.getCurrentQueryResultis called, it first tries to get the current data from anewDataproperty stored alongside a previously created query (usinggetQuery). If data can't be found, it then tries to load data from the cache. When ano-cachefetch policy is used however, thenewDataproperty is being improperly removed beforegetCurrentQueryResulthas a chance to get it. Then when it tries to fallback on loading data from the cache, it finds no matching data, since theno-cachefetch policy means the cache isn't being used.This commit adjusts
QueryManager.queryListenerForObserversuch that is doesn't remove thenewDatathat is stored with a query, if ano-cachefetch policy is being used. This allowsQueryManager.getCurrentQueryResultto return the loadedno-cachedata.Related to the following issue comments:
#3256 (comment)
#3452 (comment)
P.S. > This PR also includes a few test file CRLF to LF conversions, so please ignore the crazy diffs.