Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust subscribe to recognize the no-cache fetch policy #3773

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

hwillson
Copy link
Member

@hwillson hwillson commented Aug 2, 2018

Currently client.subscribe calls are ignoring no-cache fetch policy settings. These changes make sure no-cache avoids writing subscription results to the cache.

Fixes #3709.
Fixes #3532.

Currently `client.subscribe` calls are ignoring `no-cache`
fetch policy settings. These changes make sure `no-cache`
avoids writing subscription results to the cache.

Fixes #3709.
Fixes #3532.
@apollo-cla
Copy link

Warnings
⚠️

❗ Big PR

Generated by 🚫 dangerJS

@hwillson hwillson merged commit 24d188e into master Aug 2, 2018
@hwillson hwillson deleted the hwillson/issue-3709 branch August 2, 2018 17:51
nuragic added a commit to nuragic/apollo-client that referenced this pull request Aug 1, 2019
nuragic added a commit to nuragic/apollo-client that referenced this pull request Jan 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants