Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservableQuery.currentResult return value docs in comment #3608

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

chentsulin
Copy link
Contributor

@chentsulin chentsulin commented Jun 22, 2018

It returns

{data: Object, error: ApolloError, loading: boolean, networkStatus: number, partial: boolean}

instead of

{result: Object, loading: boolean, networkStatus: number, partial: boolean}

@apollo-cla
Copy link

apollo-cla commented Jun 22, 2018

Fails
🚫

No CHANGELOG added.

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @chentsulin!

@hwillson hwillson merged commit 13a5116 into apollographql:master Jul 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants