-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if o.hasOwnProperty is function #3418
Conversation
"stack": [ "TypeError: o.hasOwnProperty is not a function", " at /Users/joris/CLIENT/PROJECT/node_modules/apollo-utilities/src/util/maybeDeepFreeze.ts:9:9", " at Array.forEach (<anonymous>)", " at deepFreeze (/Users/joris/CLIENT/PROJECT/node_modules/apollo-utilities/src/util/maybeDeepFreeze.ts:7:33)", " at /Users/joris/CLIENT/PROJECT/node_modules/apollo-utilities/src/util/maybeDeepFreeze.ts:14:7", " at Array.forEach (<anonymous>)", " at deepFreeze (/Users/joris/CLIENT/PROJECT/node_modules/apollo-utilities/src/util/maybeDeepFreeze.ts:7:33)", " at Object.maybeDeepFreeze (/Users/joris/CLIENT/PROJECT/node_modules/apollo-utilities/src/util/maybeDeepFreeze.ts:29:14)", " at /Users/joris/CLIENT/PROJECT/node_modules/src/core/QueryManager.ts:593:31", " at /Users/joris/CLIENT/PROJECT/node_modules/src/core/QueryManager.ts:1028:11", " at Array.forEach (<anonymous>)", " at /Users/joris/CLIENT/PROJECT/node_modules/src/core/QueryManager.ts:1027:10", " at Map.forEach (<anonymous>)", " at QueryManager.broadcastQueries (/Users/joris/CLIENT/PROJECT/node_modules/src/core/QueryManager.ts:1021:18)", " at Object.next (/Users/joris/CLIENT/PROJECT/node_modules/src/core/QueryManager.ts:1094:18)", " at notifySubscription (/Users/joris/CLIENT/PROJECT/node_modules/zen-observable/lib/Observable.js:126:18)", " at onNotify (/Users/joris/CLIENT/PROJECT/node_modules/zen-observable/lib/Observable.js:161:3)"
@jorisroling: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @jorisroling! I've adjusted things a little (switched to using Object.prototype.hasOwnProperty
instead and added tests to make sure we don't regress in the future), but we should be all set here. LGTM!
Defence against the following error we have...
Fixes #3426.