Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useFragment: keep current result on a memoized mutable object #12049

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Sep 3, 2024

Fixes #12048 - thank you for the report @maciesielka

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 9c26892

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.3 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.96 KB (-0.01% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.54 KB (-0.01% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.4 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.28 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.77 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.41 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.33 KB (0%)
import { useFragment } from "dist/react/index.js" 2.28 KB (-0.56% 🔽)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (-0.44% 🔽)

@phryneas
Copy link
Member Author

phryneas commented Sep 3, 2024

/release:pr

Copy link
Contributor

github-actions bot commented Sep 3, 2024

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-12049-20240903090547

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 5f44e5a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66d6d0a985845c0008eb3d46
😎 Deploy Preview https://deploy-preview-12049--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 9c26892
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66d73679a3dbac0008076cf0
😎 Deploy Preview https://deploy-preview-12049--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas phryneas marked this pull request as ready for review September 3, 2024 13:07
@phryneas phryneas requested review from alessbell and jerelmiller and removed request for alessbell September 3, 2024 13:07
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for getting a fix so quickly.

src/react/hooks/useFragment.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the auto-cleanup 🤖 label Sep 3, 2024
@phryneas phryneas merged commit a67727e into main Sep 3, 2024
41 of 42 checks passed
@phryneas phryneas deleted the pr/fix-12048 branch September 3, 2024 16:21
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useFragment does not re-render as expected in v3.11.5
3 participants