Change usages of the GraphQLError type to GraphQLFormattedError.
#11789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7fa5fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Funny enough, nothing here fails for me locally. I'll have to take a closer look. |
|
@phryneas is this something we want to move forward with? If so, what is left to be done? |
|
Thanks for bringing this up! |
phryneas
commented
Jul 8, 2024
src/errors/__tests__/ApolloError.ts
Outdated
|
|
||
| expect(graphQLError).toBeInstanceOf(GraphQLError); | ||
| // test equality of enumberable fields. non-enumerable fields will differ | ||
| expect({ ...graphQLError }).toStrictEqual({ ...original }); |
There was a problem hiding this comment.
After writing this test I'm less convinced that this is the path forward - it's not straightforward to deserialize a serialized GraphQLError as the serialized variant is missing a lot of information and the constructor doesn't even accept locations.
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phryneas
changed the title
GraphQLError type to GraphQLFormattedError.
jerelmiller
approved these changes
Jul 9, 2024
Merged
Merged
Josh-Walker-GM
added a commit
to redwoodjs/redwood
that referenced
this pull request
Jul 24, 2024
See: #11034. This was extracted from that one without the experimental package upgrade. Hmm looks like we'll have to do some refactoring due to apollographql/apollo-client#11789.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11787
This would be one direction of going at this.
The other way of going about it would be to change our usage of the
GraphQLErrortype to theGraphQLErrorFromResponsetype that I created here, with everything exceptmessagebeing optional.We'll have to discuss that internally - putting it on the agenda for next meeting.