Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DocumentTransform to utilities package to avoid circular dependency #10937

Merged
merged 2 commits into from
May 31, 2023

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented May 31, 2023

Fixes #10935

Moves the DocumentTransform class to the utilities sub-package to avoid a circular dependency between the core and cache sub-packages.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: 520cfc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 36.55 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 42.97 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.44 KB (-0.08% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.3 KB (-0.08% 🔽)
import { useQuery } from "dist/react/index.js" 4.35 KB (-0.14% 🔽)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (-0.13% 🔽)
import { useMutation } from "dist/react/index.js" 2.57 KB (-0.04% 🔽)
import { useSubscription } from "dist/react/index.js" 2.34 KB (-0.05% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" 3.46 KB (-0.09% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" 2.89 KB (0%)
import { useReadQuery } from "dist/react/index.js" 1.65 KB (+0.12% 🔺)
import { useFragment } from "dist/react/index.js" 2.12 KB (-0.14% 🔽)

@jerelmiller jerelmiller requested review from benjamn, phryneas and alessbell and removed request for benjamn and phryneas May 31, 2023 16:10
@jerelmiller
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10937-20230531161611.

@jerelmiller
Copy link
Member Author

Can confirm this snapshot release fixes the core issue.

@jerelmiller jerelmiller merged commit eea44eb into release-3.8 May 31, 2023
@jerelmiller jerelmiller deleted the fix-circular-dep branch May 31, 2023 16:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants