useFragment: remove returnPartialData option
#10836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 784fe04 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
phryneas
commented
May 4, 2023
Comment on lines
-43
to
-55
| // Since the above definition of UseFragmentOptions can be hard to parse without | ||
| // help from TypeScript/VSCode, here are the intended fields and their types. | ||
| // Uncomment this code to check that it's consistent with the definition above. | ||
| // | ||
| // export interface UseFragmentOptions<TData, TVars> { | ||
| // from: string | StoreObject | Reference; | ||
| // fragment: DocumentNode | TypedDocumentNode<TData, TVars>; | ||
| // fragmentName?: string; | ||
| // optimistic?: boolean; | ||
| // variables?: TVars; | ||
| // returnPartialData?: boolean; | ||
| // canonizeResults?: boolean; | ||
| // } |
There was a problem hiding this comment.
I removed this comment and added a type test for this interface shape instead.
phryneas
commented
May 4, 2023
| @@ -84,9 +62,10 @@ export function useFragment_experimental< | |||
|
|
|||
| const diffOptions: Cache.DiffOptions<TData, TVars> = { | |||
| ...rest, | |||
| returnPartialData: true, | |||
There was a problem hiding this comment.
forcing returnPartialData to true in case someone isn't using TypeScript and keeps using the option.
jerelmiller
approved these changes
May 5, 2023
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: