-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix includeUnusedVariables
not working with BatchHttpLink
#10754
fix includeUnusedVariables
not working with BatchHttpLink
#10754
Conversation
@sincraianul: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Name | Link |
---|---|
🔨 Latest commit | 5e4c894 |
🦋 Changeset detectedLatest commit: b301242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this closes #8824 |
@benjamn @alessbell @bignimbus @hwillson @jerelmiller @phryneas Would be awesome to get a release for this ASAP as it's something critical to our use case. Thanks! |
Hi @sincraianul 👋 Thanks for taking the time to look into this and opening a PR! While an argument can be made for targeting this at a patch release (since the I'll make that change and we'll get this reviewed as soon as we can. Thanks! |
a262d59
to
26e0aa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this @sincraianul 🔥 🔥. We will make sure this goes out with the next v3.8.0-alpha.x
release!
Checklist: