Skip not skipping query in useQuery

[egemenuzunali]

Intended outcome:
Setting skip to true in useQuery params should skip the query.

Actual outcome:
Setting skip to true does not skip the query when refetch is used

How to reproduce the issue:
Create a query with skip params while also using refetch

Versions

Sorry to open this again but the fix mentioned in #6190 #6752 did not fix the problem, please see the thread

[jpvajda]

Possibly related to #9765

[jpvajda]

@benjamn FYI.

[bsk26]

We're seeing the issue on 3.6.6 with the following parameters to useQuery (and no refetch),

		{
			variables: { id },
			skip: true,
			fetchPolicy: 'cache-and-network',
			nextFetchPolicy: 'cache-first',
		}

We have workarounds but it is important for us that Apollo Client is reliable. The issue is especially bad because skip only intermittently fails: it appears it correctly skips the first useQuery but fails for later queries (the second time the query is loaded). This sets a trap for engineers.

[hwillson]

@bsk26 any chance you can provide a small runnable reproduction that shows this happening?

[Titozzz]

@hwillson this is probably a duplicate of #9765 , so prob the same repro applies https://codesandbox.io/s/apollo-client-3-6-3-skip-bug-5zbl63

[jpvajda]

Thanks @Titozzz since this is covered in #9765 I'm going to close this out and we can work from the other issue.

[benjamn]

If this issue is indeed a duplicate of #9765, I'm optimistic PR #9823 will fix it.