Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionResult Type Error still on Tag 3.0.0-beta.48 #6277

Closed
BrickCarvingArtist opened this issue May 14, 2020 · 2 comments · Fixed by #6279
Closed

ExecutionResult Type Error still on Tag 3.0.0-beta.48 #6277

BrickCarvingArtist opened this issue May 14, 2020 · 2 comments · Fixed by #6279

Comments

@BrickCarvingArtist
Copy link

On tag 3.0.0-beta.48
Would you please change code in file /src/core/QueryInfo.ts to code below?

on line 2 to change

import { DocumentNode, GraphQLError } from 'graphql';

line 10 to add

import { FetchResult } from '../../client/link/core/types';

and function markResult() to change to like

function markResult<T>(result: FetchResult<T>, ...) {}

Intended outcome:
Do not throw type error.

Actual outcome:
Throw type error.

How to reproduce the issue:
Just compiled by typescript.

Versions
System:
OS: macOS 10.15.4
Binaries:
Node: 14.2.0 - /usr/local/bin/node
npm: 6.14.5 - /usr/local/bin/npm
Browsers:
Chrome: 84.0.4143.2
Safari: 13.1
npmPackages:
@apollo/client: ^3.0.0-beta.48 => 3.0.0-beta.48

@benjamn

@benjamn
Copy link
Member

benjamn commented May 14, 2020

@BrickCarvingArtist Any chance you might have time to submit a pull request? 🙏

@durchanek
Copy link
Contributor

Ran into this as well after upgrading to graphql@15.0.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants