Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running similar query twice in a component results in infinite loop #1535

Closed
scf4 opened this issue Apr 3, 2017 · 2 comments
Closed

Running similar query twice in a component results in infinite loop #1535

scf4 opened this issue Apr 3, 2017 · 2 comments

Comments

@scf4
Copy link

scf4 commented Apr 3, 2017

I'm trying to replicate the functionality of returnPartialData and have two HOCs, "ThreadData" and "ThreadDataPartial".

When I do ThreadData(ThreadDataPartial(ThreadPage))) I get stuck in an infinite rendering loop.

The only thing that stops it is changing the query inside the HOCs. They do have different query names but it doesn't make a difference. If the variables are the same (e.g., thread(id: 123) { ... }) the loop happens.

Is this the recommended way for replicating the lost functionality of returnPartialData, and if so, how do I avoid getting stuck in a loop?

@scf4 scf4 changed the title Running the same type of query results in infinite loop Running the same query twice in a component results in infinite loop Apr 3, 2017
@scf4 scf4 changed the title Running the same query twice in a component results in infinite loop Running similar query twice in a component results in infinite loop Apr 3, 2017
@helfer
Copy link
Contributor

helfer commented Apr 3, 2017

@scf4 Thanks for opening an issue! Could you provide more information on what exact queries you are running? A reproduction using react-apollo-error-template would be best.

@helfer
Copy link
Contributor

helfer commented May 3, 2017

Closing for lack of activity.

@helfer helfer closed this as completed May 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants