Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools is always enabled regardless if devtools.enabled is false #12198

Closed
codedepot-jhoncel opened this issue Dec 9, 2024 · 3 comments
Closed
Labels
🏓 awaiting-contributor-response requires input from a contributor

Comments

@codedepot-jhoncel
Copy link

codedepot-jhoncel commented Dec 9, 2024

Issue Description

The new config devtools.enabled from ApolloClient doesn't seem to work. Devtools is always enabled even when you set the value to false or when running in production environments. On the contrary, using the now deprecated connectToDevTools works just fine.

Link to Reproduction

https://codesandbox.io/p/sandbox/cool-firefly-5lcwkm

Reproduction Steps

  1. Visit the codesandbox preview URL in a separate tab.
  2. Open the Apollo devtools extension (I use Chrome).
  3. Notice that the extension is still enabled even when configured to be disabled.

Expected result:
Disabling the devtools should show the following prompt.
image

Actual result:
The extension was able to log the queries and display the cached contents.
image
image

@apollo/client version

3.11.4

@jerelmiller
Copy link
Member

Hey @codedepot-jhoncel 👋

This should have been fixed with version 3.11.10 via #12093. Can you upgrade to at least that version and see if it helps?

@jerelmiller jerelmiller added the 🏓 awaiting-contributor-response requires input from a contributor label Dec 9, 2024
@codedepot-jhoncel
Copy link
Author

Hey @jerelmiller, thanks for the quick reply. I confirm updating to the latest version (v3.12.2) fixed the issue. Thanks again.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏓 awaiting-contributor-response requires input from a contributor
Projects
None yet
Development

No branches or pull requests

2 participants