Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data masking] Warning for field in migrate mode is overagressive #12043

Closed
jerelmiller opened this issue Aug 28, 2024 · 2 comments
Closed

[Data masking] Warning for field in migrate mode is overagressive #12043

jerelmiller opened this issue Aug 28, 2024 · 2 comments
Labels
🐞 bug 🎭 data-masking Issues/PRs related to data masking
Milestone

Comments

@jerelmiller
Copy link
Member

To aid in migrating to data masking, we've included a warning when a would-be masked field is accessed (#11919). This however is triggering too often because we have internal client code (such as cache.identify) which trigger the getter on those fields, such as when a spread operator is used. This results in a noisy console even when the end user isn't actually accessing those fields.

@jerelmiller
Copy link
Member Author

Fixed in #12116

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Development

No branches or pull requests

1 participant