Inconsistent behavior of skip option in useQuery leading to stale results

[hangindev]

Issue Description

Consider the following component:

function Component({ id, skip }) {
  const { data } = useQuery(GET_DATA, { variables: { id }, skip });
  return data;
}

If the variables change while the query is being skipped, I would expect that, when the component re-renders with skip = false, the query is made with up-to-date variables and data would then reflect the GraphQL query result with those variables applied. However, in some cases (see link to reproduction), the data remains stale and the query is never fetched.

Link to Reproduction

https://codesandbox.io/p/sandbox/dazzling-violet-9p6hlz

Reproduction Steps

1. Click "Toggle View" twice
2. Change character
3. Click "Toggle View" again
4. Observe stale view data

@apollo/client version

3.9.5

[phryneas]

Thank you for the reproduction!

Just some notes:

From digging a bit, it seems that in the fetchPolicy: "standby" case, updateWatch is not called, which results in updateLastDiff being called without options for the wrong variables - and without options, we cannot identify that the variables are actually wrong.
As a result, the outdated result gets merged in with the new variables.